From 7846160a639d308574f35409cc211863c7eb3fa5 Mon Sep 17 00:00:00 2001
From: Ry Dahl <ry@tinyclouds.org>
Date: Fri, 1 Nov 2019 00:54:54 -0400
Subject: [PATCH] clean up (#3)

Use .cc instead of .cpp
---
 .github/workflows/ci.yml                    |  2 ++
 BUILD.gn                                    |  8 ++++----
 build.rs                                    | 12 +-----------
 src/inspector/{channel.cpp => channel.cc}   |  0
 src/inspector/{client.cpp => client.cc}     |  0
 src/platform/{task.cpp => task.cc}          |  0
 src/{string_buffer.cpp => string_buffer.cc} |  0
 7 files changed, 7 insertions(+), 15 deletions(-)
 rename src/inspector/{channel.cpp => channel.cc} (100%)
 rename src/inspector/{client.cpp => client.cc} (100%)
 rename src/platform/{task.cpp => task.cc} (100%)
 rename src/{string_buffer.cpp => string_buffer.cc} (100%)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 8c772722..2ec91803 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -87,3 +87,5 @@ jobs:
         run: |
           rustup component add clippy
           cargo clippy --all-targets --release --locked -- -D clippy::all
+
+      # TODO cpplint
diff --git a/BUILD.gn b/BUILD.gn
index 8f372386..49d9f4d5 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -3,10 +3,10 @@ import("//third_party/v8/gni/v8.gni")
 
 v8_static_library("rusty_v8") {
   sources = [
-    "src/inspector/channel.cpp",
-    "src/inspector/client.cpp",
-    "src/platform/task.cpp",
-    "src/string_buffer.cpp",
+    "src/inspector/channel.cc",
+    "src/inspector/client.cc",
+    "src/platform/task.cc",
+    "src/string_buffer.cc",
   ]
   deps = [
     "//build/config:shared_library_deps",
diff --git a/build.rs b/build.rs
index ee204cb2..793866b8 100644
--- a/build.rs
+++ b/build.rs
@@ -43,15 +43,6 @@ fn main() {
   }
 }
 
-// TODO(ry) Remove
-fn disable_depot_tools_update() {
-  Command::new("python")
-    .arg("third_party/depot_tools/update_depot_tools_toggle.py")
-    .arg("--disable")
-    .status()
-    .expect("update_depot_tools_toggle.py failed");
-}
-
 fn git_submodule_update() {
   println!("cargo:warning=Running git submodule update");
   Command::new("git")
@@ -70,8 +61,6 @@ fn gclient_sync() {
   if !third_party.join(&gclient_rel).exists() {
     git_submodule_update();
   }
-  disable_depot_tools_update();
-  // Command::new(gclient config http://src.chromium.org/svn/trunk/src
 
   println!(
     "cargo:warning=Running gclient sync to download V8. This could take a while."
@@ -97,6 +86,7 @@ fn gclient_sync() {
 
 fn cc_wrapper(gn_args: &mut Vec<String>, sccache_path: &Path) {
   gn_args.push(format!("cc_wrapper={:?}", sccache_path));
+
   // Disable treat_warnings_as_errors until this sccache bug is fixed:
   // https://github.com/mozilla/sccache/issues/264
   if cfg!(target_os = "windows") {
diff --git a/src/inspector/channel.cpp b/src/inspector/channel.cc
similarity index 100%
rename from src/inspector/channel.cpp
rename to src/inspector/channel.cc
diff --git a/src/inspector/client.cpp b/src/inspector/client.cc
similarity index 100%
rename from src/inspector/client.cpp
rename to src/inspector/client.cc
diff --git a/src/platform/task.cpp b/src/platform/task.cc
similarity index 100%
rename from src/platform/task.cpp
rename to src/platform/task.cc
diff --git a/src/string_buffer.cpp b/src/string_buffer.cc
similarity index 100%
rename from src/string_buffer.cpp
rename to src/string_buffer.cc