foster/denoland-rusty-v8
0
0
Fork 0
mirror of https://github.com/denoland/rusty_v8.git synced 2025-01-22 06:09:47 -05:00
Code Issues Activity

Fix bad assumption in static_assert (#668)

Browse source 
v8::Location is the size of two ints, not the size of one size_t.

`2 * sizeof(int) == sizeof(size_t)` on 64 bits architectures but not on
32 bits architectures.

Fixes #667.
This commit is contained in:
Ben Noordhuis 2021-04-19 16:43:58 +02:00 • committed by GitHub
parent 2f7809ffe9
commit 84f1241b68
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/binding.cc
View file

@ -52,7 +52,7 @@ static_assert(sizeof(v8::ReturnValue<v8::Value>) == sizeof(size_t) * 1,
static_assert(sizeof(v8::TryCatch) == sizeof(size_t) * 6, static_assert(sizeof(v8::TryCatch) == sizeof(size_t) * 6,
"TryCatch size mismatch"); "TryCatch size mismatch");
static_assert(sizeof(v8::Location) == sizeof(size_t) * 1, static_assert(sizeof(v8::Location) == sizeof(int) * 2,
"Location size mismatch"); "Location size mismatch");
static_assert(sizeof(v8::SnapshotCreator) == sizeof(size_t) * 1, static_assert(sizeof(v8::SnapshotCreator) == sizeof(size_t) * 1,

2
src/module.rs
View file

@ -195,7 +195,7 @@ extern "C" {
/// A location in JavaScript source. /// A location in JavaScript source.
#[repr(C)] #[repr(C)]
#[derive(Debug)] #[derive(Debug)]
pub struct Location([usize; 1]); pub struct Location([i32; 2]);
impl Location { impl Location {
pub fn get_line_number(&self) -> int { pub fn get_line_number(&self) -> int {