foster/denoland-rusty-v8
0
0
Fork 0
mirror of https://github.com/denoland/rusty_v8.git synced 2025-02-01 20:24:56 -05:00
Code Issues Activity

Add Drop impl for CFunctionInfo (#1451)

Browse source 
This deallocates the C++ allocation, preventing a memory leak

Co-authored-by: Matt Mastracci <matthew@mastracci.com>
This commit is contained in:
Aaron 2024-04-13 10:07:43 -04:00 • committed by GitHub
parent ab742578f6
commit f42a8e41e0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/binding.cc
View file

@ -2139,6 +2139,8 @@ v8::CFunctionInfo* v8__CFunctionInfo__New(
return info.release();
}
void v8__CFunctionInfo__DELETE(v8::CFunctionInfo* self) { delete self; }
const v8::FunctionTemplate* v8__FunctionTemplate__New(
v8::Isolate* isolate, v8::FunctionCallback callback,
const v8::Value* data_or_null, const v8::Signature* signature_or_null,

7
src/fast_api.rs
View file

@ -20,6 +20,7 @@ extern "C" {
args_info: *const CTypeInfo,
repr: Int64Representation,
) -> *mut CFunctionInfo;
fn v8__CFunctionInfo__DELETE(this: &mut CFunctionInfo);
}
#[repr(C)]
@ -47,6 +48,12 @@ impl CFunctionInfo {
}
}
impl Drop for CFunctionInfo {
fn drop(&mut self) {
unsafe { v8__CFunctionInfo__DELETE(self) };
}
}
#[repr(C)]
#[derive(Debug)]
pub struct CTypeInfo(Opaque);