From 62c52bbcb8125c1f1accfcb8c1bd9403c720368a Mon Sep 17 00:00:00 2001 From: Gusted Date: Wed, 24 Jan 2024 16:58:40 +0100 Subject: [PATCH] config: Fix typo - Ref: https://codeberg.org/forgejo/forgejo/pulls/2226 --- docs/admin/config-cheat-sheet.md | 2 +- docs/admin/recommendations.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/admin/config-cheat-sheet.md b/docs/admin/config-cheat-sheet.md index fbafd314..7c4cde8f 100644 --- a/docs/admin/config-cheat-sheet.md +++ b/docs/admin/config-cheat-sheet.md @@ -447,7 +447,7 @@ The following configuration set `Content-Type: application/vnd.android.package-a - `MAX_IDLE_CONNS` **2**: Max idle database connections on connection pool, default is 2 - this will be capped to `MAX_OPEN_CONNS`. - `CONN_MAX_LIFETIME` **0 or 3s**: Sets the maximum amount of time a DB connection may be reused - default is 0, meaning there is no limit (except on MySQL/MariaDB where it is 3s - see #6804 & #7071). - `AUTO_MIGRATION` **true**: Whether execute database models migrations automatically. -- `SLOW_QUERY_TRESHOLD`: **5s**: Sets the threshold for SQL queries before they are logged as slow queries in the log. +- `SLOW_QUERY_THRESHOLD`: **5s**: Sets the threshold for SQL queries before they are logged as slow queries in the log. Please see #8540 & #8273 for further discussion of the appropriate values for `MAX_OPEN_CONNS`, `MAX_IDLE_CONNS` & `CONN_MAX_LIFETIME` and their relation to port exhaustion. diff --git a/docs/admin/recommendations.md b/docs/admin/recommendations.md index 5d7c885e..01a63839 100644 --- a/docs/admin/recommendations.md +++ b/docs/admin/recommendations.md @@ -78,4 +78,4 @@ AcceptEnv GIT_PROTOCOL ### Database performance -When trying to undertand poor database performance in conjunction with Forgejo, it is useful to set `[database].SLOW_QUERY_TRESHOLD` to a value lower than the default (5 seconds). This ensures that SQL queries that are slow, but not too slow to meet the default value, are logged and can provide insight into what kind of SQL queries are slow, moreover, this is useful information for Forgejo contributors to find the code where this SQL query is executed and understand the context. +When trying to undertand poor database performance in conjunction with Forgejo, it is useful to set `[database].SLOW_QUERY_THRESHOLD` to a value lower than the default (5 seconds). This ensures that SQL queries that are slow, but not too slow to meet the default value, are logged and can provide insight into what kind of SQL queries are slow, moreover, this is useful information for Forgejo contributors to find the code where this SQL query is executed and understand the context.