foster/forgejo
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2025-01-20 16:50:28 -05:00
Code Issues Wiki Activity

fix(ui): hide git note add button for commit if commit already has a note (#6613)

Browse source 
Regression from f5c0570533

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6613
Reviewed-by: 0ko <0ko@noreply.codeberg.org>
Co-authored-by: Beowulf <beowulf@beocode.eu>
Co-committed-by: Beowulf <beowulf@beocode.eu>
This commit is contained in:
Beowulf 2025-01-18 19:39:42 +00:00 • committed by 0ko
parent e35afe475a
commit d68e0d3e39
2 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
templates/repo/commit_page.tmpl
View file

@ -128,9 +128,11 @@
</form> </form>
</div> </div>
</div> </div>
<div id="commit-notes-add-button" class="item"> {{if not .NoteRendered}}
{{ctx.Locale.Tr "repo.diff.git-notes.add"}} <div id="commit-notes-add-button" class="item">
</div> {{ctx.Locale.Tr "repo.diff.git-notes.add"}}
</div>
{{end}}
</div> </div>
</div> </div>
{{end}} {{end}}

3
tests/e2e/git-notes.test.e2e.ts
View file

@ -8,6 +8,9 @@ test('Change git note', async ({page}) => {
let response = await page.goto('/user2/repo1/commit/65f1bf27bc3bf70f64657658635e66094edbcb4d'); let response = await page.goto('/user2/repo1/commit/65f1bf27bc3bf70f64657658635e66094edbcb4d');
expect(response?.status()).toBe(200); expect(response?.status()).toBe(200);
// An add button should not be present, because the commit already has a commit note
await expect(page.locator('#commit-notes-add-button')).toHaveCount(0);
await page.locator('#commit-notes-edit-button').click(); await page.locator('#commit-notes-edit-button').click();
let textarea = page.locator('textarea[name="notes"]'); let textarea = page.locator('textarea[name="notes"]');