mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2025-02-18 20:12:34 -05:00
376a2e19ea
Using SELECT `%s` FROM `%s` WHERE 0 = 1 to assert the existence of a column is simple but noisy: it shows errors in the migrations that are confusing for Forgejo admins because they are not actual errors. Use introspection instead, which is more complicated but leads to the same result. Add a test that ensures it works as expected, for all database types. Although the migration is run for all database types, it does not account for various scenarios and is never tested in the case a column does not exist. Refs: https://codeberg.org/forgejo/forgejo/issues/6583 Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6591 Reviewed-by: Otto <otto@codeberg.org> Co-authored-by: Earl Warren <contact@earl-warren.org> Co-committed-by: Earl Warren <contact@earl-warren.org>
41 lines
922 B
Go
41 lines
922 B
Go
// Copyright 2025 The Forgejo Authors.
|
|
// SPDX-License-Identifier: GPL-3.0-or-later
|
|
|
|
package v1_23 //nolint
|
|
|
|
import (
|
|
"testing"
|
|
|
|
migration_tests "code.gitea.io/gitea/models/migrations/test"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
"xorm.io/xorm/schemas"
|
|
)
|
|
|
|
func Test_GiteaLastDrop(t *testing.T) {
|
|
type Badge struct {
|
|
ID int64 `xorm:"pk autoincr"`
|
|
Slug string
|
|
}
|
|
|
|
x, deferable := migration_tests.PrepareTestEnv(t, 0, new(Badge))
|
|
defer deferable()
|
|
if x == nil || t.Failed() {
|
|
return
|
|
}
|
|
|
|
getColumn := func() *schemas.Column {
|
|
tables, err := x.DBMetas()
|
|
require.NoError(t, err)
|
|
require.Len(t, tables, 1)
|
|
table := tables[0]
|
|
require.Equal(t, "badge", table.Name)
|
|
return table.GetColumn("slug")
|
|
}
|
|
|
|
require.NotNil(t, getColumn(), "slug column exists")
|
|
require.NoError(t, GiteaLastDrop(x))
|
|
require.Nil(t, getColumn(), "slug column was deleted")
|
|
// idempotent
|
|
require.NoError(t, GiteaLastDrop(x))
|
|
}
|