foster/liabru-matter-js
0
0
Fork 0
mirror of https://github.com/liabru/matter-js.git synced 2025-01-31 18:14:55 -05:00
Code Issues Wiki Activity

Change mouse.position to mouse.absolute

Browse source 
When using a device with `devicePixelRatio` other than 1 and applying `pixelRatio` on Renderer (e.g. `pixelRatio: "auto"`), mouse constraints don't behave correctly. They use `mouse.position` which is a relative position, so, for example, dragging an elastic object on such devices wouldn't occur at the object's location.

**How to produce**:
Try [slingshot demo](https://brm.io/matter-js/demo/#slingshot) on a mobile device with a pixel ratio other than 1.
This commit is contained in:
Mojtaba Javan 2020-04-08 20:26:22 +04:30 • committed by GitHub
parent 5a0079df1b
commit 83e46c00a6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/constraint/MouseConstraint.js
View file

@ -48,7 +48,7 @@ var Bounds = require('../geometry/Bounds');
var constraint = Constraint.create({
label: 'Mouse Constraint',
pointA: mouse.position,
pointA: mouse.absolute,
pointB: { x: 0, y: 0 },
length: 0.01,
stiffness: 0.1,
@ -99,14 +99,14 @@ var Bounds = require('../geometry/Bounds');
if (!constraint.bodyB) {
for (var i = 0; i < bodies.length; i++) {
body = bodies[i];
if (Bounds.contains(body.bounds, mouse.position)
if (Bounds.contains(body.bounds, mouse.absolute)
&& Detector.canCollide(body.collisionFilter, mouseConstraint.collisionFilter)) {
for (var j = body.parts.length > 1 ? 1 : 0; j < body.parts.length; j++) {
var part = body.parts[j];
if (Vertices.contains(part.vertices, mouse.position)) {
constraint.pointA = mouse.position;
if (Vertices.contains(part.vertices, mouse.absolute)) {
constraint.pointA = mouse.absolute;
constraint.bodyB = mouseConstraint.body = body;
constraint.pointB = { x: mouse.position.x - body.position.x, y: mouse.position.y - body.position.y };
constraint.pointB = { x: mouse.absolute.x - body.position.x, y: mouse.absolute.y - body.position.y };
constraint.angleB = body.angle;
Sleeping.set(body, false);
@ -119,7 +119,7 @@ var Bounds = require('../geometry/Bounds');
}
} else {
Sleeping.set(constraint.bodyB, false);
constraint.pointA = mouse.position;
constraint.pointA = mouse.absolute;
}
} else {
constraint.bodyB = mouseConstraint.body = null;