From 24bef1e54bff1608425978b00bd0d7b8a9a7c81f Mon Sep 17 00:00:00 2001
From: Ben Noordhuis <info@bnoordhuis.nl>
Date: Sat, 7 Aug 2021 23:33:53 +0200
Subject: [PATCH] chore: test String object serialization (#747)

Serializing `new String("")` requires that the wire format header is
written, otherwise V8 assumes an incompatible legacy wire format when
deserializing.
---
 tests/test_api.rs | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tests/test_api.rs b/tests/test_api.rs
index 808a9a02..9b0ee6ad 100644
--- a/tests/test_api.rs
+++ b/tests/test_api.rs
@@ -4444,6 +4444,9 @@ fn value_serializer_and_deserializer() {
 
 #[test]
 fn value_serializer_and_deserializer_js_objects() {
+  use v8::ValueDeserializerHelper;
+  use v8::ValueSerializerHelper;
+
   let buffer;
   let mut array_buffers = ArrayBuffers::new();
   {
@@ -4466,6 +4469,7 @@ fn value_serializer_and_deserializer_js_objects() {
         44.444,
         99999.55434344,
         "test",
+        new String("test"),
         [1, 2, 3],
         {a: "tt", add: "tsqqqss"}
       ]"#,
@@ -4473,6 +4477,7 @@ fn value_serializer_and_deserializer_js_objects() {
     .unwrap();
     let mut value_serializer =
       Custom1Value::serializer(scope, &mut array_buffers);
+    value_serializer.write_header();
     assert_eq!(value_serializer.write_value(context, objects), Some(true));
 
     buffer = value_serializer.release();
@@ -4489,6 +4494,7 @@ fn value_serializer_and_deserializer_js_objects() {
 
     let mut value_deserializer =
       Custom1Value::deserializer(scope, &buffer, &mut array_buffers);
+    assert_eq!(value_deserializer.read_header(context), Some(true));
     let name = v8::String::new(scope, "objects").unwrap();
     let objects: v8::Local<v8::Value> =
       value_deserializer.read_value(context).unwrap();
@@ -4509,6 +4515,7 @@ fn value_serializer_and_deserializer_js_objects() {
           44.444,
           99999.55434344,
           "test",
+          new String("test"),
           [1, 2, 3],
           {a: "tt", add: "tsqqqss"}
         ];