foster/rusty-v8
0
0
Fork 0
mirror of https://github.com/denoland/rusty_v8.git synced 2025-03-09 13:38:51 -04:00
Code Issues Activity

Add Isolate::has_pending_background_tasks (#724)

Browse source
This commit is contained in:
Bartek Iwańczuk 2021-07-02 20:17:48 +02:00 • committed by GitHub
parent 1e533a152e
commit 45006fb7e7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/binding.cc
View file

@ -312,6 +312,10 @@ void v8__Isolate__SetWasmStreamingCallback(v8::Isolate* isolate,
isolate->SetWasmStreamingCallback(callback);
}
bool v8__Isolate__HasPendingBackgroundTasks(v8::Isolate* isolate) {
return isolate->HasPendingBackgroundTasks();
}
void v8__Isolate__CreateParams__CONSTRUCT(
uninit_t<v8::Isolate::CreateParams>* buf) {
construct_in_place<v8::Isolate::CreateParams>(buf);

9
src/isolate.rs
View file

@ -232,11 +232,11 @@ extern "C" {
function: *const Function,
);
fn v8__Isolate__SetAllowAtomicsWait(isolate: *mut Isolate, allow: bool);
fn v8__Isolate__SetWasmStreamingCallback(
isolate: *mut Isolate,
callback: extern "C" fn(*const FunctionCallbackInfo),
);
fn v8__Isolate__HasPendingBackgroundTasks(isolate: *const Isolate) -> bool;
fn v8__HeapProfiler__TakeHeapSnapshot(
isolate: *mut Isolate,
@ -655,6 +655,13 @@ impl Isolate {
unsafe { v8__Isolate__SetWasmStreamingCallback(self, trampoline::<F>()) }
}
/// Returns true if there is ongoing background work within V8 that will
/// eventually post a foreground task, like asynchronous WebAssembly
/// compilation.
pub fn has_pending_background_tasks(&self) -> bool {
unsafe { v8__Isolate__HasPendingBackgroundTasks(self) }
}
/// Disposes the isolate. The isolate must not be entered by any
/// thread to be disposable.
unsafe fn dispose(&mut self) {

2
tests/test_api.rs
View file

@ -4726,6 +4726,7 @@ fn wasm_streaming_callback() {
.then(result => globalThis.result = result);
"#;
eval(scope, script).unwrap();
assert!(scope.has_pending_background_tasks());
let global = context.global(scope);
let name = v8::String::new(scope, "result").unwrap().into();
@ -4739,6 +4740,7 @@ fn wasm_streaming_callback() {
assert!(global.get(scope, name).unwrap().is_null());
ws.finish();
assert!(!scope.has_pending_background_tasks());
assert!(global.get(scope, name).unwrap().is_null());
scope.perform_microtask_checkpoint();