foster/rusty-v8
0
0
Fork 0
mirror of https://github.com/denoland/rusty_v8.git synced 2025-03-09 21:47:00 -04:00
Code Issues Activity

Fix ValueDeserializer::read_value() lifetime (#609)

Browse source 
The return value should have the lifetime of the context, not the
deserializer.

Fixes #607.
This commit is contained in:
Ben Noordhuis 2021-02-10 07:27:27 +01:00 • committed by GitHub
parent 9a8f6443fe
commit 5dc6117dd7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/value_deserializer.rs
View file

@ -261,7 +261,10 @@ pub trait ValueDeserializerHelper {
.into() .into()
} }
fn read_value(&mut self, context: Local<Context>) -> Option<Local<Value>> { fn read_value<'s>(
&mut self,
context: Local<'s, Context>,
) -> Option<Local<'s, Value>> {
unsafe { unsafe {
Local::from_raw(v8__ValueDeserializer__ReadValue( Local::from_raw(v8__ValueDeserializer__ReadValue(
self.get_cxx_value_deserializer(), self.get_cxx_value_deserializer(),
@ -413,10 +416,10 @@ impl<'a, 's> ValueDeserializer<'a, 's> {
} }
} }
pub fn read_value( pub fn read_value<'t>(
&mut self, &mut self,
context: Local<Context>, context: Local<'t, Context>,
) -> Option<Local<Value>> { ) -> Option<Local<'t, Value>> {
(*self.value_deserializer_heap).read_value(context) (*self.value_deserializer_heap).read_value(context)
} }
} }

2
tests/test_api.rs
View file

@ -4240,6 +4240,7 @@ fn value_serializer_and_deserializer_js_objects() {
let name = v8::String::new(scope, "objects").unwrap(); let name = v8::String::new(scope, "objects").unwrap();
let objects: v8::Local<v8::Value> = let objects: v8::Local<v8::Value> =
value_deserializer.read_value(context).unwrap(); value_deserializer.read_value(context).unwrap();
drop(value_deserializer);
context.global(scope).set(scope, name.into(), objects); context.global(scope).set(scope, name.into(), objects);
@ -4343,6 +4344,7 @@ fn value_serializer_and_deserializer_array_buffers() {
let name = v8::String::new(scope, "objects").unwrap(); let name = v8::String::new(scope, "objects").unwrap();
let objects: v8::Local<v8::Value> = let objects: v8::Local<v8::Value> =
value_deserializer.read_value(context).unwrap(); value_deserializer.read_value(context).unwrap();
drop(value_deserializer);
context.global(scope).set(scope, name.into(), objects); context.global(scope).set(scope, name.into(), objects);