foster/rusty-v8
0
0
Fork 0
mirror of https://github.com/denoland/rusty_v8.git synced 2025-03-09 21:47:00 -04:00
Code Issues Activity

fix: remove race in terminate_execution test (#736)

Browse source 
The test started a new thread that slept for a bit, then terminated the
isolate, assuming that the delay was long enough for the isolate and the
context to get fully initialized. It wasn't.

Fixes #710.
This commit is contained in:
Ben Noordhuis 2021-07-11 22:32:34 +02:00 • committed by GitHub
parent d0da52a0ea
commit b56902c306
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
tests/test_api.rs
View file

@ -829,6 +829,11 @@ fn terminate_execution() {
let isolate = &mut v8::Isolate::new(Default::default()); let isolate = &mut v8::Isolate::new(Default::default());
let (tx, rx) = std::sync::mpsc::channel::<bool>(); let (tx, rx) = std::sync::mpsc::channel::<bool>();
let handle = isolate.thread_safe_handle(); let handle = isolate.thread_safe_handle();
let scope = &mut v8::HandleScope::new(isolate);
let context = v8::Context::new(scope);
let scope = &mut v8::ContextScope::new(scope, context);
let t = std::thread::spawn(move || { let t = std::thread::spawn(move || {
// allow deno to boot and run // allow deno to boot and run
std::thread::sleep(std::time::Duration::from_millis(300)); std::thread::sleep(std::time::Duration::from_millis(300));
@ -839,10 +844,7 @@ fn terminate_execution() {
tx.send(false).ok(); tx.send(false).ok();
}); });
let scope = &mut v8::HandleScope::new(isolate); // Run an infinite loop, which should be terminated.
let context = v8::Context::new(scope);
let scope = &mut v8::ContextScope::new(scope, context);
// Rn an infinite loop, which should be terminated.
let source = v8::String::new(scope, "for(;;) {}").unwrap(); let source = v8::String::new(scope, "for(;;) {}").unwrap();
let r = v8::Script::compile(scope, source, None); let r = v8::Script::compile(scope, source, None);
let script = r.unwrap(); let script = r.unwrap();