foster/bitcoin-bitcoin-core
0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-02 09:46:52 -05:00
Code Issues Activity

script: remove out-of-date snprintf TODO

Browse source 
that was resolved in PR27036 "test: Remove last uses of snprintf and simplify"
and while here, fix up 2 words in docs to make the spelling linter green again.
This commit is contained in:
Jon Atack 2023-02-15 14:03:37 -08:00
parent 0e015146bd
commit 30a3230e86
3 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/blockencodings.h
View file

@ -135,7 +135,7 @@ protected:
public: public:
CBlockHeader header; CBlockHeader header;
// Can be overriden for testing // Can be overridden for testing
using CheckBlockFn = std::function<bool(const CBlock&, BlockValidationState&, const Consensus::Params&, bool, bool)>; using CheckBlockFn = std::function<bool(const CBlock&, BlockValidationState&, const Consensus::Params&, bool, bool)>;
CheckBlockFn m_check_block_mock{nullptr}; CheckBlockFn m_check_block_mock{nullptr};

2
src/net.cpp
View file

@ -1671,7 +1671,7 @@ void CConnman::ThreadOpenConnections(const std::vector<std::string> connect)
// Therefore, we do not add them to addrman in the first place. // Therefore, we do not add them to addrman in the first place.
// In case previously unreachable networks become reachable // In case previously unreachable networks become reachable
// (e.g. in case of -onlynet changes by the user), fixed seeds will // (e.g. in case of -onlynet changes by the user), fixed seeds will
// be loaded only for networks for which we have no addressses. // be loaded only for networks for which we have no addresses.
seed_addrs.erase(std::remove_if(seed_addrs.begin(), seed_addrs.end(), seed_addrs.erase(std::remove_if(seed_addrs.begin(), seed_addrs.end(),
[&fixed_seed_networks](const CAddress& addr) { return fixed_seed_networks.count(addr.GetNetwork()) == 0; }), [&fixed_seed_networks](const CAddress& addr) { return fixed_seed_networks.count(addr.GetNetwork()) == 0; }),
seed_addrs.end()); seed_addrs.end());

2
test/lint/lint-locale-dependence.py
View file

@ -34,8 +34,6 @@
# #
# See https://doc.qt.io/qt-5/qcoreapplication.html#locale-settings and # See https://doc.qt.io/qt-5/qcoreapplication.html#locale-settings and
# https://stackoverflow.com/a/34878283 for more details. # https://stackoverflow.com/a/34878283 for more details.
#
# TODO: Reduce KNOWN_VIOLATIONS by replacing uses of locale dependent snprintf with strprintf.
import re import re
import sys import sys