Merge bitcoin/bitcoin#28753: test: Remove feature_txindex_compatibility.py

897d6dd42b Remove feature_txindex_compatibility.py in V27 (Brandon Odiwuor)

Pull request description:

  Fixes https://github.com/bitcoin/bitcoin/issues/28421, see [#28195 (comment)](fa8685597e (r1311494362))

  Remove feature_txindex_compatibility.py in V27, follow up to https://github.com/bitcoin/bitcoin/pull/28195 being merged which is included in v26

ACKs for top commit:
  maflcko:
    lgtm ACK 897d6dd42b
  theStack:
    ACK 897d6dd42b
  stickies-v:
    ACK 897d6dd42b

Tree-SHA512: 53102d39f6fdbdcf1bb13b6feb2f446b0e9e8e3fe294c0e6fe37e7731713fb9fd5b048e19b6edf80579f5edbcf762b51d56d57bdcda67ec3527706891dc3572b

test/functional/feature_txindex_compatibility.py

@@ -1,66 +0,0 @@
-#!/usr/bin/env python3
-# Copyright (c) 2021-2022 The Bitcoin Core developers
-# Distributed under the MIT software license, see the accompanying
-# file COPYING or http://www.opensource.org/licenses/mit-license.php.
-"""Test that legacy txindex will be disabled on upgrade.
-
-Previous releases are required by this test, see test/README.md.
-"""
-
-import shutil
-
-from test_framework.test_framework import BitcoinTestFramework
-from test_framework.util import assert_raises_rpc_error
-from test_framework.wallet import MiniWallet
-
-
-class TxindexCompatibilityTest(BitcoinTestFramework):
-    def set_test_params(self):
-        self.num_nodes = 2
-        self.extra_args = [
-            ["-reindex", "-txindex"],
-            [],
-        ]
-
-    def skip_test_if_missing_module(self):
-        self.skip_if_no_previous_releases()
-
-    def setup_network(self):
-        self.add_nodes(
-            self.num_nodes,
-            self.extra_args,
-            versions=[
-                160300,  # Last release with legacy txindex
-                None,  # For MiniWallet, without migration code
-            ],
-        )
-        self.start_nodes()
-        self.connect_nodes(0, 1)
-
-    def run_test(self):
-        mini_wallet = MiniWallet(self.nodes[1])
-        spend_utxo = mini_wallet.get_utxo()
-        mini_wallet.send_self_transfer(from_node=self.nodes[1], utxo_to_spend=spend_utxo)
-        self.generate(self.nodes[1], 1)
-
-        self.log.info("Check legacy txindex")
-        assert_raises_rpc_error(-5, "Use -txindex", lambda: self.nodes[1].getrawtransaction(txid=spend_utxo["txid"]))
-        self.nodes[0].getrawtransaction(txid=spend_utxo["txid"])  # Requires -txindex
-
-        self.stop_nodes()
-        legacy_chain_dir = self.nodes[0].chain_path
-
-        self.log.info("Drop legacy txindex")
-        drop_index_chain_dir = self.nodes[1].chain_path
-        shutil.rmtree(drop_index_chain_dir)
-        shutil.copytree(legacy_chain_dir, drop_index_chain_dir)
-        # Build txindex from scratch and check there is no error this time
-        self.start_node(1, extra_args=["-txindex"])
-        self.wait_until(lambda: self.nodes[1].getindexinfo()["txindex"]["synced"] == True)
-        self.nodes[1].getrawtransaction(txid=spend_utxo["txid"])  # Requires -txindex
-
-        self.stop_nodes()
-
-
-if __name__ == "__main__":
-    TxindexCompatibilityTest().main()

test/functional/test_runner.py

@@ -357,7 +357,6 @@ BASE_SCRIPTS = [
     'rpc_scanblocks.py',
     'p2p_sendtxrcncl.py',
     'rpc_scantxoutset.py',
-    'feature_txindex_compatibility.py',
     'feature_unsupported_utxo_db.py',
     'feature_logging.py',
     'feature_anchors.py',