0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-05 10:17:30 -05:00
bitcoin-bitcoin-core/src/test
W. J. van der Laan 7f7bd3111c
Merge bitcoin/bitcoin#22974: addrman: Improve performance of Good
57ce20307e fuzz: allow lower number of sources (Martin Zumsande)
acf656d540 fuzz: Use public interface to fill addrman tried tables (Martin Zumsande)
eb2e113df1 addrman: Improve performance of Good (Martin Zumsande)

Pull request description:

  Currently, `CAddrman::Good()` is rather slow because the process of moving an addr from new to tried involves looping over the new tables twice:
  1) In `Good_()`, there is a loop searching for a new bucket the addr is currently in, but this information is never used except for aborting if it is not found anywhere (since [this commit](e6b343d880 (diff-49d1faa58beca1ee1509a247e0331bb91f8604e30a483a7b2dea813e6cea02e2R263)) it is no longer passed to `MakeTried`)
  This is unnecessary because in a non-corrupted addrman, an address that is not in New must be either in Tried or not at all in addrman, both cases in which we'd return early in `Good_()` and never get to this point.
  I removed this loop (and left a check for `nRefCount` as a belt-and-suspenders check).

  2) In `MakeTried()`, which is called from `Good_()`, another loop removes all instances of this address from new. This can be spedup by stopping the search at  `nRefCount==0`. Further reductions in `nRefCount` would only lead to an assert anyway.
  Moreover, the search can be started at the bucket determined by the source of the addr for which `Good` was called, so that if it is present just once in New, no further buckets need to be checked.

  While calls to `Good()` are not that frequent normally, the performance gain is clearly seen in the fuzz target `addman_serdeser`, where, because of the slowness in creating a decently filled addrman, a shortcut was created that would directly populate the tried tables by reaching into addrman's internals, bypassing `Good()` (#21129).
  I removed this workaround in the second commit: Using `Good()` is still slower by a factor of 2 (down from a factor of ~60 before), but I think that this compensated by the advantages of not having to reach into the internal structures of addrman  (see https://github.com/jnewbery/bitcoin/pull/18#issuecomment-775218676).

  [Edit]: For benchmark results see https://github.com/bitcoin/bitcoin/pull/22974#issuecomment-919435266 and https://github.com/bitcoin/bitcoin/pull/22974#issuecomment-920445700 - the benchmark `AddrManGood` shows a significant speedup by a factor >100.

ACKs for top commit:
  naumenkogs:
    ACK 57ce20307e
  jnewbery:
    ACK 57ce20307e
  laanwj:
    Code review ACK 57ce20307e
  theStack:
    ACK 57ce20307e
  vasild:
    ACK 57ce20307e

Tree-SHA512: fb6dfc198f2e28bdbb41cef9709828f22d83b4be0e640a3155ca42e771b6f58466de1468f54d773e794f780a79113f9f7d522032e87fdd75bdc4d99330445198
2021-09-20 19:47:55 +02:00
..
data test: Add missing test for empty P2WSH redeem 2021-05-01 10:12:11 +02:00
fuzz fuzz: allow lower number of sources 2021-09-16 00:50:48 +02:00
util Merge bitcoin/bitcoin#22219: multiprocess: Start using init makeNode, makeChain, etc methods 2021-09-16 08:47:38 +08:00
addrman_tests.cpp Raise InitError when peers.dat is invalid or corrupted 2021-09-09 09:20:43 +02:00
allocator_tests.cpp test: remove BasicTestingSetup from allocator unit tests 2021-05-28 19:14:07 +08:00
amount_tests.cpp test: remove BasicTestingSetup from amount unit tests 2021-05-28 19:14:07 +08:00
arith_uint256_tests.cpp test: remove BasicTestingSetup from arith_uint256 unit tests 2021-05-28 19:14:07 +08:00
base32_tests.cpp test: remove BasicTestingSetup from base32 unit tests 2021-05-28 19:14:07 +08:00
base58_tests.cpp refactor: Remove useless extern keyword 2021-05-10 09:09:24 +02:00
base64_tests.cpp test: remove BasicTestingSetup from base64 unit tests 2021-05-28 19:14:08 +08:00
bech32_tests.cpp test: remove BasicTestingSetup from bech32 unit tests 2021-05-28 19:14:08 +08:00
bip32_tests.cpp Stricter BIP32 decoding and test vector 5 2021-08-30 12:02:04 -04:00
blockchain_tests.cpp
blockencodings_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
blockfilter_index_tests.cpp scripted-diff: test: Use existing chainman in unit tests 2021-06-10 15:04:39 -04:00
blockfilter_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
bloom_tests.cpp Treat CDataStream bytes as uint8_t 2020-11-23 21:19:50 +01:00
bswap_tests.cpp test: remove BasicTestingSetup from bswap unit tests 2021-05-28 19:14:08 +08:00
checkqueue_tests.cpp scripted-diff: remove MakeUnique<T>() 2021-03-11 13:45:14 +08:00
coins_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
coinstatsindex_tests.cpp scripted-diff: test: Use existing chainman in unit tests 2021-06-10 15:04:39 -04:00
compilerbug_tests.cpp test: remove BasicTestingSetup from compilerbug unit tests 2021-05-28 19:14:08 +08:00
compress_tests.cpp refactor: Replace &foo[0] with foo.data() 2021-05-04 06:55:31 +02:00
crypto_tests.cpp [crypto] Fix K1/K2 use in ChaCha20-Poly1305 AEAD 2021-06-23 09:46:38 -07:00
cuckoocache_tests.cpp refactor: replace Boost shared_mutex with std shared_mutex in cuckoocache tests 2021-02-02 12:35:40 +08:00
dbwrapper_tests.cpp refactor: Switch serialize to uint8_t (1/n) 2021-05-31 14:56:17 +02:00
denialofservice_tests.cpp Close minor startup race between main and scheduler threads 2021-07-30 16:34:09 -06:00
descriptor_tests.cpp Remove priv option for ToNormalizedString 2021-06-24 13:49:22 -04:00
flatfile_tests.cpp scripted-diff: Change ArgsManager.GetDataDirPath() to ArgsManager.GetDataDirBase() in tests 2021-05-24 10:29:57 +02:00
fs_tests.cpp scripted-diff: Change ArgsManager.GetDataDirPath() to ArgsManager.GetDataDirBase() in tests 2021-05-24 10:29:57 +02:00
getarg_tests.cpp scripted-diff: Replace m_args with m_local_args in getarg_tests.cpp 2021-04-18 11:59:28 +02:00
hash_tests.cpp test: remove BasicTestingSetup from hash unit tests 2021-05-28 19:14:08 +08:00
i2p_tests.cpp scripted-diff: Replace GetDataDir() calls with gArgs.GetDataDirNet() calls 2021-05-24 10:29:58 +02:00
interfaces_tests.cpp refactor: Remove chainparams arg from CChainState member functions 2021-06-13 09:43:54 +02:00
key_io_tests.cpp refactor: Remove useless extern keyword 2021-05-10 09:09:24 +02:00
key_tests.cpp Add CKey::SignSchnorr function for BIP 340/341 signing 2021-06-12 12:25:28 -07:00
logging_tests.cpp Make unexpected time type in BCLog::LogMsg() a compile-time error 2021-09-07 19:19:31 +02:00
main.cpp
Makefile
mempool_tests.cpp test: Reset mocktime in the common setup 2021-04-14 17:38:07 +02:00
merkle_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
merkleblock_tests.cpp test: remove BasicTestingSetup from merkleblock tests 2021-05-28 19:14:08 +08:00
miner_tests.cpp test: Add missing include 2021-08-05 09:53:03 +02:00
multisig_tests.cpp Make all SignatureChecker explicit about missing data 2021-03-15 17:29:39 -07:00
net_peer_eviction_tests.cpp refactor: move GetRandomNodeEvictionCandidates() to test utilities 2021-07-06 17:28:15 +02:00
net_tests.cpp Merge bitcoin/bitcoin#22648: doc, test: improve i2p/tor docs and i2p reachable unit tests 2021-08-26 12:44:46 +02:00
netbase_tests.cpp p2p: ignore torv2-in-ipv6 addresses in SetLegacyIPv6() 2021-06-03 13:36:42 +02:00
pmt_tests.cpp
policy_fee_tests.cpp test: remove BasicTestingSetup from policy_fee unit tests 2021-05-28 19:14:09 +08:00
policyestimator_tests.cpp
pow_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
prevector_tests.cpp
raii_event_tests.cpp scripted-diff: Bump copyright headers 2020-12-31 09:45:41 +01:00
random_tests.cpp
README.md doc: test: unittest segfault gdb 2021-09-16 18:02:55 -04:00
reverselock_tests.cpp test: remove BasicTestingSetup from reverse_lock unit tests 2021-05-28 19:14:09 +08:00
rpc_tests.cpp test: Reset mocktime in the common setup 2021-04-14 17:38:07 +02:00
sanity_tests.cpp compat: remove memcpy -> memmove backwards compatibility alias 2021-03-10 14:31:10 +08:00
scheduler_tests.cpp refactor: remove boost::thread_group usage 2021-01-29 15:39:44 +08:00
script_p2sh_tests.cpp Make all SignatureChecker explicit about missing data 2021-03-15 17:29:39 -07:00
script_standard_tests.cpp Add TaprootBuilder class 2021-05-24 12:14:16 -07:00
script_tests.cpp Remove default nHashTypeIn arguments to MutableTransactionSignatureCreator 2021-08-20 14:29:23 -04:00
scriptnum10.h
scriptnum_tests.cpp refactor: replace sizeof(a)/sizeof(a[0]) by std::size (C++17) 2021-01-31 17:35:16 +01:00
serfloat_tests.cpp refactor: replace remaining binascii method calls 2021-08-16 19:30:56 +01:00
serialize_tests.cpp refactor: Switch serialize to uint8_t (1/n) 2021-05-31 14:56:17 +02:00
settings_tests.cpp scripted-diff: Change ArgsManager.GetDataDirPath() to ArgsManager.GetDataDirBase() in tests 2021-05-24 10:29:57 +02:00
sighash_tests.cpp refactor: Remove useless extern keyword 2021-05-10 09:09:24 +02:00
sigopcount_tests.cpp refactor: Pass script verify flags as uint32_t 2021-06-14 08:02:45 +02:00
skiplist_tests.cpp
sock_tests.cpp net: flag relevant Sock methods with [[nodiscard]] 2021-04-13 17:26:20 +02:00
streams_tests.cpp test: Correct outstanding -Werror=sign-compare errors 2021-06-09 12:34:21 -04:00
sync_tests.cpp test: remove BasicTestingSetup from sync unit tests 2021-05-28 19:14:09 +08:00
system_tests.cpp build: Fix Boost Process compatibility with mingw-w64 compiler 2021-07-01 12:16:47 +03:00
timedata_tests.cpp Make GetWarnings() return bilingual_str 2020-06-10 15:01:20 +03:00
torcontrol_tests.cpp test: remove BasicTestingSetup from torcontrol unit tests 2021-05-28 19:14:09 +08:00
transaction_tests.cpp test: Always clear reject reason in IsStandard tx test 2021-09-02 09:40:07 +02:00
txindex_tests.cpp scripted-diff: test: Use existing chainman in unit tests 2021-06-10 15:04:39 -04:00
txrequest_tests.cpp Report and verify expirations 2020-10-12 12:14:53 -07:00
txvalidation_tests.cpp scripted-diff: test: Use existing chainman in unit tests 2021-06-10 15:04:39 -04:00
txvalidationcache_tests.cpp Merge bitcoin/bitcoin#13533: [tests] Reduced number of validations in tx_validationcache_tests 2021-07-24 10:36:58 +02:00
uint256_tests.cpp test: remove BasicTestingSetup from uint256 unit tests 2021-05-28 19:14:09 +08:00
util_tests.cpp tests: Add TrimString(...) tests 2021-09-02 13:20:08 +08:00
util_threadnames_tests.cpp test: remove BasicTestingSetup from util_threadnames unit tests 2021-05-28 19:14:09 +08:00
validation_block_tests.cpp test: Set BIP34Height = 2 for regtest 2021-06-18 20:58:03 +02:00
validation_chainstate_tests.cpp Move pblocktree global to BlockManager 2021-07-15 13:54:09 +02:00
validation_chainstatemanager_tests.cpp validation: make CChainState::m_mempool optional 2021-07-13 11:11:35 -04:00
validation_flush_tests.cpp refactor: no mempool arg to GetCoinsCacheSizeState 2021-07-13 11:16:30 -04:00
validation_tests.cpp fuzz: Add utxo_snapshot target 2021-05-16 11:34:27 +02:00
validationinterface_tests.cpp
versionbits_tests.cpp tests: remove ComputeBlockVersion shortcut from versionbits tests 2021-06-30 08:19:12 +10:00

Unit tests

The sources in this directory are unit test cases. Boost includes a unit testing framework, and since Bitcoin Core already uses Boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible).

The build system is set up to compile an executable called test_bitcoin that runs all of the unit tests. The main source file for the test library is found in util/setup_common.cpp.

Compiling/running unit tests

Unit tests will be automatically compiled if dependencies were met in ./configure and tests weren't explicitly disabled.

After configuring, they can be run with make check.

To run the unit tests manually, launch src/test/test_bitcoin. To recompile after a test file was modified, run make and then run the test again. If you modify a non-test file, use make -C src/test to recompile only what's needed to run the unit tests.

To add more unit tests, add BOOST_AUTO_TEST_CASE functions to the existing .cpp files in the test/ directory or add new .cpp files that implement new BOOST_AUTO_TEST_SUITE sections.

To run the GUI unit tests manually, launch src/qt/test/test_bitcoin-qt

To add more GUI unit tests, add them to the src/qt/test/ directory and the src/qt/test/test_main.cpp file.

Running individual tests

test_bitcoin has some built-in command-line arguments; for example, to run just the getarg_tests verbosely:

test_bitcoin --log_level=all --run_test=getarg_tests -- DEBUG_LOG_OUT

log_level controls the verbosity of the test framework, which logs when a test case is entered, for example. The DEBUG_LOG_OUT after the two dashes redirects the debug log, which would normally go to a file in the test datadir (BasicTestingSetup::m_path_root), to the standard terminal output.

... or to run just the doubledash test:

test_bitcoin --run_test=getarg_tests/doubledash

Run test_bitcoin --help for the full list.

Adding test cases

To add a new unit test file to our test suite you need to add the file to src/Makefile.test.include. The pattern is to create one test file for each class or source file for which you want to create unit tests. The file naming convention is <source_filename>_tests.cpp and such files should wrap their tests in a test suite called <source_filename>_tests. For an example of this pattern, see uint256_tests.cpp.

Logging and debugging in unit tests

make check will write to a log file foo_tests.cpp.log and display this file on failure. For running individual tests verbosely, refer to the section above.

To write to logs from unit tests you need to use specific message methods provided by Boost. The simplest is BOOST_TEST_MESSAGE.

For debugging you can launch the test_bitcoin executable with gdbor lldb and start debugging, just like you would with any other program:

gdb src/test/test_bitcoin

Segmentation faults

If you hit a segmentation fault during a test run, you can diagnose where the fault is happening by running gdb ./src/test/test_bitcoin and then using the bt command within gdb.

Another tool that can be used to resolve segmentation faults is valgrind.

If for whatever reason you want to produce a core dump file for this fault, you can do that as well. By default, the boost test runner will intercept system errors and not produce a core file. To bypass this, add --catch_system_errors=no to the test_bitcoin arguments and ensure that your ulimits are set properly (e.g. ulimit -c unlimited).

Running the tests and hitting a segmentation fault should now produce a file called core (on Linux platforms, the file name will likely depend on the contents of /proc/sys/kernel/core_pattern).

You can then explore the core dump using

gdb src/test/test_bitcoin core

(gbd) bt  # produce a backtrace for where a segfault occurred