mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-02-23 12:33:26 -05:00

6666713041
refactor: Rename fs::path::u8string() to fs::path::utf8string() (MarcoFalke)856c88776f
ArgsManager: return path by value from GetBlocksDirPath() (Vasil Dimov)fa3d9304e8
refactor: Remove pre-C++20 fs code (MarcoFalke)fa00098e1a
Add tests for C++20 std::u8string (MarcoFalke)fa2bac08c2
refactor: Avoid copy/move in fs.h (MarcoFalke)faea30227b
refactor: Use C++20 std::chrono::days (MarcoFalke) Pull request description: This: * Removes dead code. * Avoids unused copies in some places. * Adds copies in other places for safety. ACKs for top commit: achow101: ACK6666713041
ryanofsky: Code review ACK6666713041
. Just documentation change since last review. stickies-v: re-ACK6666713041
Tree-SHA512: 6176e44f30b310d51632ec2d3827c3819905d0ddc6a4b57acfcb6cfa1f9735176da75ee8ed4a4abd1296cb0b83bee9374cc6f91ffac87c19b63c435eeadf3f46
166 lines
5.1 KiB
C++
166 lines
5.1 KiB
C++
// Copyright (c) 2011-2022 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
//
|
|
#include <test/util/setup_common.h>
|
|
#include <util/fs.h>
|
|
#include <util/fs_helpers.h>
|
|
|
|
#include <boost/test/unit_test.hpp>
|
|
|
|
#include <fstream>
|
|
#include <ios>
|
|
#include <string>
|
|
|
|
BOOST_FIXTURE_TEST_SUITE(fs_tests, BasicTestingSetup)
|
|
|
|
BOOST_AUTO_TEST_CASE(fsbridge_pathtostring)
|
|
{
|
|
std::string u8_str = "fs_tests_₿_🏃";
|
|
std::u8string str8{u8"fs_tests_₿_🏃"};
|
|
BOOST_CHECK_EQUAL(fs::PathToString(fs::PathFromString(u8_str)), u8_str);
|
|
BOOST_CHECK_EQUAL(fs::u8path(u8_str).utf8string(), u8_str);
|
|
BOOST_CHECK_EQUAL(fs::path(str8).utf8string(), u8_str);
|
|
BOOST_CHECK(fs::path(str8).u8string() == str8);
|
|
BOOST_CHECK_EQUAL(fs::PathFromString(u8_str).utf8string(), u8_str);
|
|
BOOST_CHECK_EQUAL(fs::PathToString(fs::u8path(u8_str)), u8_str);
|
|
#ifndef WIN32
|
|
// On non-windows systems, verify that arbitrary byte strings containing
|
|
// invalid UTF-8 can be round tripped successfully with PathToString and
|
|
// PathFromString. On non-windows systems, paths are just byte strings so
|
|
// these functions do not do any encoding. On windows, paths are Unicode,
|
|
// and these functions do encoding and decoding, so the behavior of this
|
|
// test would be undefined.
|
|
std::string invalid_u8_str = "\xf0";
|
|
BOOST_CHECK_EQUAL(invalid_u8_str.size(), 1);
|
|
BOOST_CHECK_EQUAL(fs::PathToString(fs::PathFromString(invalid_u8_str)), invalid_u8_str);
|
|
#endif
|
|
}
|
|
|
|
BOOST_AUTO_TEST_CASE(fsbridge_stem)
|
|
{
|
|
std::string test_filename = "fs_tests_₿_🏃.dat";
|
|
std::string expected_stem = "fs_tests_₿_🏃";
|
|
BOOST_CHECK_EQUAL(fs::PathToString(fs::PathFromString(test_filename).stem()), expected_stem);
|
|
}
|
|
|
|
BOOST_AUTO_TEST_CASE(fsbridge_fstream)
|
|
{
|
|
fs::path tmpfolder = m_args.GetDataDirBase();
|
|
// tmpfile1 should be the same as tmpfile2
|
|
fs::path tmpfile1 = tmpfolder / fs::u8path("fs_tests_₿_🏃");
|
|
fs::path tmpfile2 = tmpfolder / fs::path(u8"fs_tests_₿_🏃");
|
|
{
|
|
std::ofstream file{tmpfile1};
|
|
file << "bitcoin";
|
|
}
|
|
{
|
|
std::ifstream file{tmpfile2};
|
|
std::string input_buffer;
|
|
file >> input_buffer;
|
|
BOOST_CHECK_EQUAL(input_buffer, "bitcoin");
|
|
}
|
|
{
|
|
std::ifstream file{tmpfile1, std::ios_base::in | std::ios_base::ate};
|
|
std::string input_buffer;
|
|
file >> input_buffer;
|
|
BOOST_CHECK_EQUAL(input_buffer, "");
|
|
}
|
|
{
|
|
std::ofstream file{tmpfile2, std::ios_base::out | std::ios_base::app};
|
|
file << "tests";
|
|
}
|
|
{
|
|
std::ifstream file{tmpfile1};
|
|
std::string input_buffer;
|
|
file >> input_buffer;
|
|
BOOST_CHECK_EQUAL(input_buffer, "bitcointests");
|
|
}
|
|
{
|
|
std::ofstream file{tmpfile2, std::ios_base::out | std::ios_base::trunc};
|
|
file << "bitcoin";
|
|
}
|
|
{
|
|
std::ifstream file{tmpfile1};
|
|
std::string input_buffer;
|
|
file >> input_buffer;
|
|
BOOST_CHECK_EQUAL(input_buffer, "bitcoin");
|
|
}
|
|
{
|
|
// Join an absolute path and a relative path.
|
|
fs::path p = fsbridge::AbsPathJoin(tmpfolder, fs::u8path("fs_tests_₿_🏃"));
|
|
BOOST_CHECK(p.is_absolute());
|
|
BOOST_CHECK_EQUAL(tmpfile1, p);
|
|
}
|
|
{
|
|
// Join two absolute paths.
|
|
fs::path p = fsbridge::AbsPathJoin(tmpfile1, tmpfile2);
|
|
BOOST_CHECK(p.is_absolute());
|
|
BOOST_CHECK_EQUAL(tmpfile2, p);
|
|
}
|
|
{
|
|
// Ensure joining with empty paths does not add trailing path components.
|
|
BOOST_CHECK_EQUAL(tmpfile1, fsbridge::AbsPathJoin(tmpfile1, ""));
|
|
BOOST_CHECK_EQUAL(tmpfile1, fsbridge::AbsPathJoin(tmpfile1, {}));
|
|
}
|
|
}
|
|
|
|
BOOST_AUTO_TEST_CASE(rename)
|
|
{
|
|
const fs::path tmpfolder{m_args.GetDataDirBase()};
|
|
|
|
const fs::path path1{tmpfolder / "a"};
|
|
const fs::path path2{tmpfolder / "b"};
|
|
|
|
const std::string path1_contents{"1111"};
|
|
const std::string path2_contents{"2222"};
|
|
|
|
{
|
|
std::ofstream file{path1};
|
|
file << path1_contents;
|
|
}
|
|
|
|
{
|
|
std::ofstream file{path2};
|
|
file << path2_contents;
|
|
}
|
|
|
|
// Rename path1 -> path2.
|
|
BOOST_CHECK(RenameOver(path1, path2));
|
|
|
|
BOOST_CHECK(!fs::exists(path1));
|
|
|
|
{
|
|
std::ifstream file{path2};
|
|
std::string contents;
|
|
file >> contents;
|
|
BOOST_CHECK_EQUAL(contents, path1_contents);
|
|
}
|
|
fs::remove(path2);
|
|
}
|
|
|
|
#ifndef __MINGW64__ // no symlinks on mingw
|
|
BOOST_AUTO_TEST_CASE(create_directories)
|
|
{
|
|
// Test fs::create_directories workaround.
|
|
const fs::path tmpfolder{m_args.GetDataDirBase()};
|
|
|
|
const fs::path dir{tmpfolder / "a"};
|
|
fs::create_directory(dir);
|
|
BOOST_CHECK(fs::exists(dir));
|
|
BOOST_CHECK(fs::is_directory(dir));
|
|
BOOST_CHECK(!fs::create_directories(dir));
|
|
|
|
const fs::path symlink{tmpfolder / "b"};
|
|
fs::create_directory_symlink(dir, symlink);
|
|
BOOST_CHECK(fs::exists(symlink));
|
|
BOOST_CHECK(fs::is_symlink(symlink));
|
|
BOOST_CHECK(fs::is_directory(symlink));
|
|
BOOST_CHECK(!fs::create_directories(symlink));
|
|
|
|
fs::remove(symlink);
|
|
fs::remove(dir);
|
|
}
|
|
#endif // __MINGW64__
|
|
|
|
BOOST_AUTO_TEST_SUITE_END()
|