mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-25 12:51:55 -05:00

History

MarcoFalke a063647413 Merge bitcoin/bitcoin#23280 : init: Coalesce Chainstate loading sequence between {,non-}unittest codepaths `7f15eff2dd` style-only: Remove redundant scope in Chainstate (Carl Dong) `89bec827fd` Collapse the 2 cs_main locks in LoadChainstate (Carl Dong) `3b1584b794` Remove all #include // for comments (Carl Dong) `9a5a5a3d08` test/setup: Use LoadChainstate (Carl Dong) `c541da0d62` node/chainstate: Add options for in-memory DBs (Carl Dong) `ceb9790341` node/caches: Remove intermediate variables (Carl Dong) `ac4bf138b8` node/caches: Extract cache calculation logic (Carl Dong) `15f2e33bb3` validation: VerifyDB only needs Consensus::Params (Carl Dong) `4da9c076d1` node/chainstate: Decouple from ShutdownRequested (Carl Dong) `05441c2dc5` node/chainstate: Decouple from GetTime (Carl Dong) `2414ebc18b` init: Delay RPC block notif until warmup finished (Carl Dong) `8d466a8504` Move -checkblocks LogPrintf to AppInitMain (Carl Dong) `aad8d59789` node/chainstate: Reduce coupling of LogPrintf (Carl Dong) `b345979a2b` node/chainstate: Decouple from concept of uiInterface (Carl Dong) `ca7c0b934d` Split off VerifyLoadedChainstate (Carl Dong) `adf4912d77` node/chainstate: Remove do/while loop (Carl Dong) `975235ca0a` Move init logistics message for BAD_GENESIS_BLOCK to init.cpp (Carl Dong) `8715658983` Move mempool nullptr Assert out of LoadChainstate (Carl Dong) `9162a4f93e` node/chainstate: Decouple from concept of NodeContext (Carl Dong) `c7a5c46e6f` node/chainstate: Decouple from ArgsManager (Carl Dong) `ae9121f958` node/chainstate: Decouple from stringy errors (Carl Dong) `cbac28b72f` node/chainstate: Decouple from GetTimeMillis (Carl Dong) `cb64af9635` node: Extract chainstate loading sequence (Carl Dong) Pull request description: This PR: 1. Coalesce the Chainstate loading sequence between `AppInitMain` and `TestingSetup` (which makes it more tested) 2. Makes the Chainstate loading sequence reusable in preparation for future work extracting out our consensus engine. Code-wise, this PR: 1. Extracts `AppInitMain`'s Chainstate loading sequence into a `::LoadChainstateSequence` function 2. Makes this `::LoadChainstateSequence` function reusable by 1. Decoupling it from various concepts (`ArgsManager`, `uiInterface`, etc) 2. Making it report errors using an `enum` rather than by setting a `bilingual_str` 3. Makes `TestingSetup` use this new `::LoadChainstateSequence` Reviewers: Aside from commentary, I've also included `git diff` flags of interest in the commit messages which I hope will aid review! ACKs for top commit: ryanofsky: Code review ACK `7f15eff2dd`. Thanks for updates! MarcoFalke: review ACK `7f15eff2dd` 💳 Tree-SHA512: fb9a6cbd1c511a52b477c62a5e68e53a8be5dec2fff0e44a279966afb91efbab44bf1fe7c6b1519f8464ecc25f42dd4bae8e1efbf55ee91fc90fa0b92e3a83e2		2021-12-10 17:17:43 +01:00
..
blockfilter.cpp	move-only: Move *Disk functions to blockstorage	2021-04-05 20:26:14 +02:00
blockfilter.h
chainstate.h	Merge bitcoin/bitcoin#23155 : rpc: various fixups for dumptxoutset	2021-12-02 10:35:02 +01:00
logging.cpp	scripted-diff: remove MakeUnique<T>()	2021-03-11 13:45:14 +08:00
logging.h	scripted-diff: Bump copyright headers	2020-12-31 09:45:41 +01:00
mining.cpp	style: Sort file list after rename	2021-11-16 10:05:21 +01:00
mining.h	fuzz: Add utxo_snapshot target	2021-05-16 11:34:27 +02:00
net.cpp	scripted-diff: Use clang-tidy syntax for C++ named arguments	2021-11-19 12:41:47 +01:00
net.h	Merge bitcoin/bitcoin#19499 : p2p: Make timeout mockable and type safe, speed up test	2021-12-10 10:02:12 +01:00
README.md	doc: Add documentation for new test/lib	2019-11-06 11:56:53 -05:00
script.cpp	fuzz: [refactor] Use IsValidFlagCombination in signature_checker fuzz target	2021-03-30 10:42:45 +02:00
script.h	fuzz: [refactor] Use IsValidFlagCombination in signature_checker fuzz target	2021-03-30 10:42:45 +02:00
setup_common.cpp	Remove all #include // for * comments	2021-12-07 14:48:49 -05:00
setup_common.h	test/setup: Use LoadChainstate	2021-12-07 14:48:49 -05:00
str.cpp
str.h	[test] move string helper functions into test library	2019-11-25 01:33:17 +01:00
transaction_utils.cpp	scripted-diff: Bump copyright headers	2020-04-16 13:33:09 -04:00
transaction_utils.h	scripted-diff: TxoutType C++11 scoped enum class	2020-06-21 06:41:55 -04:00
validation.cpp	test: Mock IBD in net_processing fuzzers	2020-11-07 07:50:59 +01:00
validation.h	test: Mock IBD in net_processing fuzzers	2020-11-07 07:50:59 +01:00
wallet.cpp	bench: Use DescriptorScriptPubKeyMan for wallet things	2021-10-15 15:23:07 -04:00
wallet.h	[test] move wallet helper functions into test library	2019-11-25 16:40:09 +01:00

README.md

Test library

This contains files for the test library, which is used by the test binaries (unit tests, benchmarks, fuzzers, gui tests).

Generally, the files in this folder should be well-separated modules. New code should be added to existing modules or (when in doubt) a new module should be created.

The utilities in here are compiled into a library, which does not hold any state. However, the main file setup_common defines the common test setup for all test binaries. The test binaries will handle the global state when they instantiate the BasicTestingSetup (or one of its derived classes).