0
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-02-24 12:41:41 -05:00
bitcoin-bitcoin-core/src/test
Ryan Ofsky c66c68345e
Merge bitcoin/bitcoin#30773: Remove unsafe uint256S() and test-only uint160S()
43cd83b0c7 test: move uint256_tests/operator_with_self to arith_uint256_tests (stickies-v)
c6c994cb2b test: remove test-only uint160S (stickies-v)
62cc4656e2 test: remove test-only uint256S (stickies-v)
adc00ad728 test: remove test-only arith_uint256S (stickies-v)
f51b237723 refactor: rpc: use uint256::FromHex for ParseHashV (stickies-v)

Pull request description:

  _Continuation of #30569._

  Since fad2991ba0, `uint256S()` has been [deprecated](fad2991ba0 (diff-800776e2dda39116e889839f69409571a5d397de048a141da7e4003bc099e3e2R138)) because it is less robust than the `base_blob::FromHex()` introduced in https://github.com/bitcoin/bitcoin/pull/30482. Specifically, it tries to recover from length-mismatches, recover from untrimmed whitespace, 0x-prefix and garbage at the end, instead of simply requiring exactly 64 hex-only characters. (see also https://github.com/bitcoin/bitcoin/pull/30532)

  This PR removes `uint256S()` (and `uint160S()`) completely, with no non-test behaviour change.

  Specifically, the main changes in this PR are:
  - the (minimal) last non-test usage of `uint256S()` in `ParseHashV()` is removed without behaviour change, which can partially be verified by cherry-picking and/or modifying [this test commit](1f2b0fa86d)).
  - the test usage of `uint{160,256}S()` is removed, largely replacing it with `uint{160,256}::FromHex()` where applicable, potentially modifying the test by removing non-hex characters or dropping the test entirely if removing non-hex characters makes it redundant
  - the now unused `uint{160,256}S()` functions are removed completely.
  - unit test coverage on converting `uint256` <-> `arith_uint256` through `UintToArith256()` and `ArithToUint256()` is beefed up, and `arith_uint256` tests are moved to `arith_uint256_tests.cpp`, removing the `uint256_tests.cpp` dependency on `uint256h`, mirroring how the code is structured.

  _Note:  `uint256::FromUserHex()` exists to more leniently construct uint256 from user input, allowing "0x" prefixes and too-short-input, as safer alternative to `uint256S()` where necessary._

ACKs for top commit:
  l0rinc:
    reACK 43cd83b0c7
  hodlinator:
    re-ACK 43cd83b0c7
  ryanofsky:
    Code review ACK 43cd83b0c7. Only code change is a small refactoring which looks good. The rest of the PR is all test changes, which I only lightly reviewed, but seem to be positive and do what's described

Tree-SHA512: 48147a4c6af671597df0f72c1b477ae4631cd2cae4645ec54d0e327611ff302c9899e344518c81242cdde82930f6ad23a3a7e6e0b80671816e9f457b9de90a5c
2024-09-10 15:41:35 -04:00
..
data refactor: Rename CTransaction::nVersion to version 2024-06-07 13:55:23 -04:00
fuzz Merge bitcoin/bitcoin#30773: Remove unsafe uint256S() and test-only uint160S() 2024-09-10 15:41:35 -04:00
util Merge bitcoin/bitcoin#30748: test: Pin and document TEST_DIR_PATH_ELEMENT, SeedRand::FIXED_SEED 2024-09-06 09:42:02 +01:00
addrman_tests.cpp test: Use span for raw data 2024-09-05 10:57:19 +02:00
allocator_tests.cpp
amount_tests.cpp test: Add tests for CFeeRate multiplication operator 2023-12-11 16:27:58 -05:00
argsman_tests.cpp testnet: Introduce Testnet4 2024-08-06 01:38:10 +02:00
arith_uint256_tests.cpp test: move uint256_tests/operator_with_self to arith_uint256_tests 2024-09-06 17:36:28 +02:00
banman_tests.cpp
base32_tests.cpp refactor: Remove Span operator==, Use std::ranges::equal 2024-08-13 07:44:31 +02:00
base58_tests.cpp refactor: Hand-replace some ParseHex -> ""_hex 2024-08-28 19:11:59 +02:00
base64_tests.cpp refactor: Remove Span operator==, Use std::ranges::equal 2024-08-13 07:44:31 +02:00
bech32_tests.cpp
bip32_tests.cpp
bip324_tests.cpp Merge bitcoin/bitcoin#30571: test: [refactor] Use m_rng directly 2024-08-28 16:56:32 +01:00
blockchain_tests.cpp scripted-diff: Modernize naming of nChainTx and nTxCount 2024-08-04 14:24:43 +02:00
blockencodings_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
blockfilter_index_tests.cpp validation: Use span for ProcessNewBlockHeaders 2024-08-30 10:17:09 +02:00
blockfilter_tests.cpp refactor: Replace ParseHashStr with FromHex 2024-07-24 17:40:18 +02:00
blockmanager_tests.cpp Merge bitcoin/bitcoin#29668: prune, rpc: Check undo data when finding pruneheight 2024-07-10 15:27:05 -04:00
bloom_tests.cpp scripted-diff: Replace ParseHex[<std::byte>]("str") -> "str"_hex[_u8] 2024-08-28 19:11:59 +02:00
bswap_tests.cpp serialization: detect byteswap builtins without autoconf tests 2024-02-28 13:42:38 +00:00
checkqueue_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
cluster_linearize_tests.cpp tests: framework for testing DepGraph class 2024-07-25 10:16:37 -04:00
CMakeLists.txt multiprocess: Add unit tests for connect, serve, and listen functions 2024-09-06 09:08:10 -04:00
coins_tests.cpp scripted-diff: Replace ParseHex[<std::byte>]("str") -> "str"_hex[_u8] 2024-08-28 19:11:59 +02:00
coinscachepair_tests.cpp test: add cache entry linked list tests 2024-08-05 19:43:56 -04:00
coinstatsindex_tests.cpp refactor: De-globalize g_signals 2024-02-15 14:37:01 +01:00
common_url_tests.cpp test: Add two more urlDecode tests 2024-04-26 08:33:56 +02:00
compilerbug_tests.cpp
compress_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
crypto_tests.cpp scripted-diff: Replace ParseHex[<std::byte>]("str") -> "str"_hex[_u8] 2024-08-28 19:11:59 +02:00
cuckoocache_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
dbwrapper_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
denialofservice_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
descriptor_tests.cpp refactor: Hand-replace some ParseHex -> ""_hex 2024-08-28 19:11:59 +02:00
disconnected_transactions.cpp
feefrac_tests.cpp Avoid explicitly computing diagram; compare based on chunks 2024-04-22 09:36:36 -04:00
flatfile_tests.cpp
fs_tests.cpp Merge bitcoin/bitcoin#29040: refactor: Remove pre-C++20 code, fs::path cleanup 2023-12-14 16:46:54 -05:00
getarg_tests.cpp util: Move util/string.h functions to util namespace 2024-05-16 10:16:08 -05:00
hash_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
headers_sync_chainwork_tests.cpp
httpserver_tests.cpp
i2p_tests.cpp test: [refactor] Pass TestOpts 2024-07-08 16:11:15 +02:00
interfaces_tests.cpp
ipc_test.capnp multiprocess: Add type conversion code for UniValue types 2023-11-28 12:35:50 -05:00
ipc_test.cpp multiprocess: Add unit tests for connect, serve, and listen functions 2024-09-06 09:08:10 -04:00
ipc_test.h multiprocess: Add unit tests for connect, serve, and listen functions 2024-09-06 09:08:10 -04:00
ipc_tests.cpp multiprocess: Add unit tests for connect, serve, and listen functions 2024-09-06 09:08:10 -04:00
key_io_tests.cpp refactor: Remove Span operator==, Use std::ranges::equal 2024-08-13 07:44:31 +02:00
key_tests.cpp refactor: Hand-replace some ParseHex -> ""_hex 2024-08-28 19:11:59 +02:00
logging_tests.cpp bench: Remove redundant logging benchmarks 2024-09-05 07:17:22 +02:00
main.cpp test: test_bitcoin: allow -testdatadir=<datadir> 2024-03-07 10:11:45 -07:00
mempool_tests.cpp refactor: Drop util::Result operator= 2024-04-25 16:08:24 -04:00
merkle_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
merkleblock_tests.cpp refactor: remove TxidFromString 2024-07-31 16:47:39 +01:00
miner_tests.cpp refactor: Hand-replace some ParseHex -> ""_hex 2024-08-28 19:11:59 +02:00
miniminer_tests.cpp
miniscript_tests.cpp scripted-diff: Replace ParseHex[<std::byte>]("str") -> "str"_hex[_u8] 2024-08-28 19:11:59 +02:00
minisketch_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
multisig_tests.cpp
net_peer_connection_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
net_peer_eviction_tests.cpp random: drop ad-hoc Shuffle in favor of std::shuffle 2024-07-06 09:06:36 -04:00
net_tests.cpp refactor: Hand-replace some ParseHex -> ""_hex 2024-08-28 19:11:59 +02:00
netbase_tests.cpp Accept "in" and "out" flags to -whitelist to allow whitelisting manual connections 2024-02-28 10:05:56 -03:00
node_warnings_tests.cpp introduce and use the generalized node::Warnings interface 2024-06-13 11:20:48 +01:00
orphanage_tests.cpp test: add check that large txs aren't put into orphanage 2024-09-03 22:23:48 +02:00
peerman_tests.cpp Always pass options to BlockAssembler constructor 2024-06-18 18:47:51 +02:00
pmt_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
policy_fee_tests.cpp
policyestimator_tests.cpp test: Disallow fee_estimator construction in ChainTestingSetup 2024-08-13 10:30:44 +02:00
pool_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
pow_tests.cpp refactor: Enforce lowercase hex digits for consteval uint256 2024-08-28 19:09:51 +02:00
prevector_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
raii_event_tests.cpp
random_tests.cpp random: drop ad-hoc Shuffle in favor of std::shuffle 2024-07-06 09:06:36 -04:00
rbf_tests.cpp Avoid explicitly computing diagram; compare based on chunks 2024-04-22 09:36:36 -04:00
README.md test: Pin and document TEST_DIR_PATH_ELEMENT 2024-09-02 09:28:52 +02:00
rest_tests.cpp
result_tests.cpp
reverselock_tests.cpp
rpc_tests.cpp Merge bitcoin/bitcoin#29015: kernel: Streamline util library 2024-06-12 17:12:54 -04:00
sanity_tests.cpp Revert "time: add runtime sanity check" 2024-03-18 16:01:08 +01:00
scheduler_tests.cpp scripted-diff: Rename SingleThreadedSchedulerClient to SerialTaskRunner 2024-02-15 14:43:14 +01:00
script_p2sh_tests.cpp kernel: De-globalize signature cache 2024-07-05 09:03:04 +02:00
script_parse_tests.cpp
script_segwit_tests.cpp
script_standard_tests.cpp scripted-diff: Replace ParseHex[<std::byte>]("str") -> "str"_hex[_u8] 2024-08-28 19:11:59 +02:00
script_tests.cpp scripted-diff: Replace ParseHex[<std::byte>]("str") -> "str"_hex[_u8] 2024-08-28 19:11:59 +02:00
scriptnum10.h
scriptnum_tests.cpp
serfloat_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
serialize_tests.cpp serialization: Add ParamsStream GetStream() method 2024-02-21 07:35:38 -05:00
settings_tests.cpp util: Move util/string.h functions to util namespace 2024-05-16 10:16:08 -05:00
sighash_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
sigopcount_tests.cpp refactor: Rename CTransaction::nVersion to version 2024-06-07 13:55:23 -04:00
skiplist_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
sock_tests.cpp
span_tests.cpp Fix CI-detected codespell warnings 2024-02-23 23:01:07 +01:00
streams_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
sync_tests.cpp
system_tests.cpp test: fixing failing system_tests/run_command under some Locales 2024-09-04 09:30:05 +03:30
timeoffsets_tests.cpp refactor: remove warnings globals 2024-06-13 11:20:49 +01:00
torcontrol_tests.cpp
transaction_tests.cpp refactor: Hand-replace some ParseHex -> ""_hex 2024-08-28 19:11:59 +02:00
translation_tests.cpp
txindex_tests.cpp refactor: De-globalize g_signals 2024-02-15 14:37:01 +01:00
txpackage_tests.cpp refactor: Hand-replace some ParseHex -> ""_hex 2024-08-28 19:11:59 +02:00
txreconciliation_tests.cpp
txrequest_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
txvalidation_tests.cpp use version=3 instead of v3 in debug strings 2024-07-02 12:20:12 +01:00
txvalidationcache_tests.cpp Merge bitcoin/bitcoin#30407: test: [refactor] Pass TestOpts 2024-07-15 17:21:55 +01:00
uint256_tests.cpp test: move uint256_tests/operator_with_self to arith_uint256_tests 2024-09-06 17:36:28 +02:00
util_tests.cpp util: Add consteval ""_hex[_v][_u8] literals 2024-08-28 19:09:51 +02:00
util_threadnames_tests.cpp Merge bitcoin/bitcoin#29015: kernel: Streamline util library 2024-06-12 17:12:54 -04:00
validation_block_tests.cpp Merge bitcoin/bitcoin#30742: kernel: Use spans instead of vectors for passing block headers to validation functions 2024-09-03 15:40:40 -04:00
validation_chainstate_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
validation_chainstatemanager_tests.cpp test: Work around boost compilation error 2024-09-06 15:57:33 +02:00
validation_flush_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00
validation_tests.cpp scripted-diff: Replace uint256S("str") -> uint256{"str"} 2024-08-05 14:51:48 +02:00
validationinterface_tests.cpp scripted-diff: Rename MainSignals to ValidationSignals 2024-02-15 14:45:51 +01:00
versionbits_tests.cpp scripted-diff: [test] Use g_rng/m_rng directly 2024-08-26 11:19:52 +02:00

Unit tests

The sources in this directory are unit test cases. Boost includes a unit testing framework, and since Bitcoin Core already uses Boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible).

The build system is set up to compile an executable called test_bitcoin that runs all of the unit tests. The main source file for the test library is found in util/setup_common.cpp.

Compiling/running unit tests

Unit tests will be automatically compiled if dependencies were met during the generation of the Bitcoin Core build system and tests weren't explicitly disabled.

Assuming the build directory is named build, the unit tests can be run with ctest --test-dir build, which includes unit tests from subtrees.

To run the unit tests manually, launch build/src/test/test_bitcoin. To recompile after a test file was modified, run cmake --build build and then run the test again. If you modify a non-test file, use cmake --build build --target test_bitcoin to recompile only what's needed to run the unit tests.

To add more unit tests, add BOOST_AUTO_TEST_CASE functions to the existing .cpp files in the test/ directory or add new .cpp files that implement new BOOST_AUTO_TEST_SUITE sections.

To run the GUI unit tests manually, launch build/src/qt/test/test_bitcoin-qt

To add more GUI unit tests, add them to the src/qt/test/ directory and the src/qt/test/test_main.cpp file.

Running individual tests

test_bitcoin accepts the command line arguments from the boost framework. For example, to run just the getarg_tests suite of tests:

build/src/test/test_bitcoin --log_level=all --run_test=getarg_tests

log_level controls the verbosity of the test framework, which logs when a test case is entered, for example.

test_bitcoin also accepts some of the command line arguments accepted by bitcoind. Use -- to separate these sets of arguments:

build/src/test/test_bitcoin --log_level=all --run_test=getarg_tests -- -printtoconsole=1

The -printtoconsole=1 after the two dashes sends debug logging, which normally goes only to debug.log within the data directory, also to the standard terminal output.

... or to run just the doubledash test:

build/src/test/test_bitcoin --run_test=getarg_tests/doubledash

test_bitcoin creates a temporary working (data) directory with a randomly generated pathname within test_common bitcoin/, which in turn is within the system's temporary directory (see temp_directory_path). This data directory looks like a simplified form of the standard bitcoind data directory. Its content will vary depending on the test, but it will always have a debug.log file, for example.

The location of the temporary data directory can be specified with the -testdatadir option. This can make debugging easier. The directory path used is the argument path appended with /test_common bitcoin/<test-name>/datadir. The directory path is created if necessary. Specifying this argument also causes the data directory not to be removed after the last test. This is useful for looking at what the test wrote to debug.log after it completes, for example. (The directory is removed at the start of the next test run, so no leftover state is used.)

$ build/src/test/test_bitcoin --run_test=getarg_tests/doubledash -- -testdatadir=/somewhere/mydatadir
Test directory (will not be deleted): "/somewhere/mydatadir/test_common bitcoin/getarg_tests/doubledash/datadir"
Running 1 test case...

*** No errors detected
$ ls -l '/somewhere/mydatadir/test_common bitcoin/getarg_tests/doubledash/datadir'
total 8
drwxrwxr-x 2 admin admin 4096 Nov 27 22:45 blocks
-rw-rw-r-- 1 admin admin 1003 Nov 27 22:45 debug.log

If you run an entire test suite, such as --run_test=getarg_tests, or all the test suites (by not specifying --run_test), a separate directory will be created for each individual test.

Run test_bitcoin --help for the full list of tests.

Adding test cases

To add a new unit test file to our test suite, you need to add the file to either src/test/CMakeLists.txt or src/wallet/test/CMakeLists.txt for wallet-related tests. The pattern is to create one test file for each class or source file for which you want to create unit tests. The file naming convention is <source_filename>_tests.cpp and such files should wrap their tests in a test suite called <source_filename>_tests. For an example of this pattern, see uint256_tests.cpp.

Logging and debugging in unit tests

ctest --test-dir build will write to the log file build/Testing/Temporary/LastTest.log. You can additionally use the --output-on-failure option to display logs of the failed tests automatically on failure. For running individual tests verbosely, refer to the section above.

To write to logs from unit tests you need to use specific message methods provided by Boost. The simplest is BOOST_TEST_MESSAGE.

For debugging you can launch the test_bitcoin executable with gdb or lldb and start debugging, just like you would with any other program:

gdb build/src/test/test_bitcoin

Segmentation faults

If you hit a segmentation fault during a test run, you can diagnose where the fault is happening by running gdb ./build/src/test/test_bitcoin and then using the bt command within gdb.

Another tool that can be used to resolve segmentation faults is valgrind.

If for whatever reason you want to produce a core dump file for this fault, you can do that as well. By default, the boost test runner will intercept system errors and not produce a core file. To bypass this, add --catch_system_errors=no to the test_bitcoin arguments and ensure that your ulimits are set properly (e.g. ulimit -c unlimited).

Running the tests and hitting a segmentation fault should now produce a file called core (on Linux platforms, the file name will likely depend on the contents of /proc/sys/kernel/core_pattern).

You can then explore the core dump using

gdb build/src/test/test_bitcoin core

(gdb) bt  # produce a backtrace for where a segfault occurred